fix: L3 数据流误报大修 (真实项目扫描发现 E004 从 422 降到 3)
- with ... as f: 上下文变量未登记 → with 块内 f 全误报 - 推导式/生成器变量: target 未登记, elt 里变量全误报 (修复: 独立作用域副本) - lambda 参数未登记 → key=lambda d 全误报 - except ... as e: handler 变量未登记 → e 全误报 - if 分支 return 提前终止未识别 → else return 后变量误报 (修复: _flow_terminates + 合并三分支) - 剩余 3 条为已知盲区: locals() 动态检查 / try handler 保守策略 (宁误勿漏) - 新增 7 项误报回归测试; 相关套件 283 passed
This commit is contained in:
1 parent
fa29e0339f
commit
08f26cdcfd
2 files changed
+113
-6
No files matched your search
+66
-6
@@ -517,11 +517,59 @@ def _flow_maybe_report(node, locals_set, defined, analyzer):
|
||||
|
||||
|
||||
def _flow_check_loads(node, locals_set, defined, analyzer):
|
||||
"""检查表达式树里的所有 Name Load"""
|
||||
"""检查表达式树里的所有 Name Load (作用域感知: 推导式/lambda 各自登记)"""
|
||||
if node is None:
|
||||
return
|
||||
for sub in ast.walk(node):
|
||||
_flow_maybe_report(sub, locals_set, defined, analyzer)
|
||||
if isinstance(node, (ast.ListComp, ast.SetComp, ast.GeneratorExp)):
|
||||
_flow_check_comp(node, locals_set, defined, analyzer)
|
||||
return
|
||||
if isinstance(node, ast.DictComp):
|
||||
_flow_check_comp(node, locals_set, defined, analyzer)
|
||||
return
|
||||
if isinstance(node, ast.Lambda):
|
||||
d = set(defined)
|
||||
for a in node.args.args + node.args.kwonlyargs:
|
||||
d.add(a.arg)
|
||||
if node.args.vararg:
|
||||
d.add(node.args.vararg.arg)
|
||||
if node.args.kwarg:
|
||||
d.add(node.args.kwarg.arg)
|
||||
_flow_check_loads(node.body, locals_set, d, analyzer)
|
||||
return
|
||||
if isinstance(node, ast.Name):
|
||||
_flow_maybe_report(node, locals_set, defined, analyzer)
|
||||
return
|
||||
for child in ast.iter_child_nodes(node):
|
||||
_flow_check_loads(child, locals_set, defined, analyzer)
|
||||
|
||||
|
||||
def _flow_check_comp(node, locals_set, defined, analyzer):
|
||||
"""推导式: target 在 elt/条件内确定有值 (Python3 推导式独立作用域, 不泄漏到外层)"""
|
||||
d = set(defined)
|
||||
for gen in node.generators:
|
||||
_flow_check_loads(gen.iter, locals_set, d, analyzer)
|
||||
for gen in node.generators:
|
||||
_flow_collect_stores(gen.target, d)
|
||||
if isinstance(node, ast.DictComp):
|
||||
_flow_check_loads(node.key, locals_set, d, analyzer)
|
||||
_flow_check_loads(node.value, locals_set, d, analyzer)
|
||||
else:
|
||||
_flow_check_loads(node.elt, locals_set, d, analyzer)
|
||||
for gen in node.generators:
|
||||
for cond in gen.ifs:
|
||||
_flow_check_loads(cond, locals_set, d, analyzer)
|
||||
|
||||
|
||||
def _flow_terminates(stmts) -> bool:
|
||||
"""语句列表是否必然终止 (末尾 return/raise, 或 if 两分支都终止)"""
|
||||
if not stmts:
|
||||
return False
|
||||
last = stmts[-1]
|
||||
if isinstance(last, (ast.Return, ast.Raise)):
|
||||
return True
|
||||
if isinstance(last, ast.If):
|
||||
return _flow_terminates(last.body) and _flow_terminates(last.orelse)
|
||||
return False
|
||||
|
||||
|
||||
def _flow_statements(stmts, locals_set, defined, analyzer):
|
||||
@@ -565,13 +613,23 @@ def _flow_statements(stmts, locals_set, defined, analyzer):
|
||||
d2 = set(defined)
|
||||
_flow_statements(stmt.body, locals_set, d1, analyzer)
|
||||
_flow_statements(stmt.orelse, locals_set, d2, analyzer)
|
||||
defined.clear()
|
||||
defined.update(d1 & d2) # 合并点: 两分支都确定才算确定
|
||||
t1 = _flow_terminates(stmt.body)
|
||||
t2 = _flow_terminates(stmt.orelse)
|
||||
if t1 and t2:
|
||||
pass # 两分支都终止, 无流出
|
||||
elif t1:
|
||||
defined.clear(); defined.update(d2) # 只有 orelse 流出
|
||||
elif t2:
|
||||
defined.clear(); defined.update(d1) # 只有 body 流出
|
||||
else:
|
||||
defined.clear(); defined.update(d1 & d2) # 都流出 → 交集
|
||||
elif isinstance(stmt, ast.Try):
|
||||
d_main = set(defined)
|
||||
_flow_statements(stmt.body, locals_set, d_main, analyzer)
|
||||
for h in stmt.handlers:
|
||||
d_h = set(defined) # 异常路径独立, 不贡献确定
|
||||
d_h = set(defined)
|
||||
if h.name:
|
||||
d_h.add(h.name) # except ... as e: e 在 handler 内确定
|
||||
_flow_statements(h.body, locals_set, d_h, analyzer)
|
||||
_flow_statements(stmt.orelse, locals_set, d_main, analyzer)
|
||||
_flow_statements(stmt.finalbody, locals_set, d_main, analyzer)
|
||||
@@ -579,6 +637,8 @@ def _flow_statements(stmts, locals_set, defined, analyzer):
|
||||
elif isinstance(stmt, ast.With):
|
||||
for item in stmt.items:
|
||||
_flow_check_loads(item.context_expr, locals_set, defined, analyzer)
|
||||
if item.optional_vars:
|
||||
_flow_collect_stores(item.optional_vars, defined) # with ... as f: f 确定
|
||||
_flow_statements(stmt.body, locals_set, defined, analyzer)
|
||||
elif isinstance(stmt, ast.Return):
|
||||
_flow_check_loads(stmt.value, locals_set, defined, analyzer)
|
||||
|
||||
Reference in new issue
Block a user