fix: L3 数据流误报大修 (真实项目扫描发现 E004 从 422 降到 3)

- with ... as f: 上下文变量未登记 → with 块内 f 全误报
- 推导式/生成器变量: target 未登记, elt 里变量全误报 (修复: 独立作用域副本)
- lambda 参数未登记 → key=lambda d 全误报
- except ... as e: handler 变量未登记 → e 全误报
- if 分支 return 提前终止未识别 → else return 后变量误报 (修复: _flow_terminates + 合并三分支)
- 剩余 3 条为已知盲区: locals() 动态检查 / try handler 保守策略 (宁误勿漏)
- 新增 7 项误报回归测试; 相关套件 283 passed
This commit is contained in:
shuiyu67 committed 2026-08-07 02:54:13 +08:00
1 parent fa29e0339f
commit 08f26cdcfd
2 files changed
+113 -6

No files matched your search

+66 -6
View File
@@ -517,11 +517,59 @@ def _flow_maybe_report(node, locals_set, defined, analyzer):
def _flow_check_loads(node, locals_set, defined, analyzer):
"""检查表达式树里的所有 Name Load"""
"""检查表达式树里的所有 Name Load (作用域感知: 推导式/lambda 各自登记)"""
if node is None:
return
for sub in ast.walk(node):
_flow_maybe_report(sub, locals_set, defined, analyzer)
if isinstance(node, (ast.ListComp, ast.SetComp, ast.GeneratorExp)):
_flow_check_comp(node, locals_set, defined, analyzer)
return
if isinstance(node, ast.DictComp):
_flow_check_comp(node, locals_set, defined, analyzer)
return
if isinstance(node, ast.Lambda):
d = set(defined)
for a in node.args.args + node.args.kwonlyargs:
d.add(a.arg)
if node.args.vararg:
d.add(node.args.vararg.arg)
if node.args.kwarg:
d.add(node.args.kwarg.arg)
_flow_check_loads(node.body, locals_set, d, analyzer)
return
if isinstance(node, ast.Name):
_flow_maybe_report(node, locals_set, defined, analyzer)
return
for child in ast.iter_child_nodes(node):
_flow_check_loads(child, locals_set, defined, analyzer)
def _flow_check_comp(node, locals_set, defined, analyzer):
"""推导式: target 在 elt/条件内确定有值 (Python3 推导式独立作用域, 不泄漏到外层)"""
d = set(defined)
for gen in node.generators:
_flow_check_loads(gen.iter, locals_set, d, analyzer)
for gen in node.generators:
_flow_collect_stores(gen.target, d)
if isinstance(node, ast.DictComp):
_flow_check_loads(node.key, locals_set, d, analyzer)
_flow_check_loads(node.value, locals_set, d, analyzer)
else:
_flow_check_loads(node.elt, locals_set, d, analyzer)
for gen in node.generators:
for cond in gen.ifs:
_flow_check_loads(cond, locals_set, d, analyzer)
def _flow_terminates(stmts) -> bool:
"""语句列表是否必然终止 (末尾 return/raise, 或 if 两分支都终止)"""
if not stmts:
return False
last = stmts[-1]
if isinstance(last, (ast.Return, ast.Raise)):
return True
if isinstance(last, ast.If):
return _flow_terminates(last.body) and _flow_terminates(last.orelse)
return False
def _flow_statements(stmts, locals_set, defined, analyzer):
@@ -565,13 +613,23 @@ def _flow_statements(stmts, locals_set, defined, analyzer):
d2 = set(defined)
_flow_statements(stmt.body, locals_set, d1, analyzer)
_flow_statements(stmt.orelse, locals_set, d2, analyzer)
defined.clear()
defined.update(d1 & d2) # 合并点: 两分支都确定才算确定
t1 = _flow_terminates(stmt.body)
t2 = _flow_terminates(stmt.orelse)
if t1 and t2:
pass # 两分支都终止, 无流出
elif t1:
defined.clear(); defined.update(d2) # 只有 orelse 流出
elif t2:
defined.clear(); defined.update(d1) # 只有 body 流出
else:
defined.clear(); defined.update(d1 & d2) # 都流出 → 交集
elif isinstance(stmt, ast.Try):
d_main = set(defined)
_flow_statements(stmt.body, locals_set, d_main, analyzer)
for h in stmt.handlers:
d_h = set(defined) # 异常路径独立, 不贡献确定
d_h = set(defined)
if h.name:
d_h.add(h.name) # except ... as e: e 在 handler 内确定
_flow_statements(h.body, locals_set, d_h, analyzer)
_flow_statements(stmt.orelse, locals_set, d_main, analyzer)
_flow_statements(stmt.finalbody, locals_set, d_main, analyzer)
@@ -579,6 +637,8 @@ def _flow_statements(stmts, locals_set, defined, analyzer):
elif isinstance(stmt, ast.With):
for item in stmt.items:
_flow_check_loads(item.context_expr, locals_set, defined, analyzer)
if item.optional_vars:
_flow_collect_stores(item.optional_vars, defined) # with ... as f: f 确定
_flow_statements(stmt.body, locals_set, defined, analyzer)
elif isinstance(stmt, ast.Return):
_flow_check_loads(stmt.value, locals_set, defined, analyzer)
+47
View File
@@ -378,6 +378,53 @@ class TestDataFlow:
keys = [(d["code"], d["line"], d["col"]) for d in issues]
assert len(keys) == len(set(keys)), f"存在重复诊断: {keys}"
# ── L3 误报回归 (真实项目扫描发现, 曾 422 条误报) ──
def test_with_as_var_ok(self, pd):
src = "def f():\n with open('x') as fh:\n return fh.read()\n"
assert "E004" not in {d["code"] for d in pd.analyze(src, "t.py")}
def test_comprehension_var_ok(self, pd):
src = "def f(items):\n return [x * 2 for x in items]\n"
assert "E004" not in {d["code"] for d in pd.analyze(src, "t.py")}
def test_nested_comprehension_ok(self, pd):
src = ("def f(rows):\n"
" names = ', '.join(t.get('name', '') for t in rows)\n"
" return names\n")
assert "E004" not in {d["code"] for d in pd.analyze(src, "t.py")}
def test_lambda_param_ok(self, pd):
src = "def f(issues):\n return sorted(issues, key=lambda d: d['x'])\n"
assert "E004" not in {d["code"] for d in pd.analyze(src, "t.py")}
def test_except_handler_var_ok(self, pd):
src = ("def f():\n"
" try:\n"
" risky()\n"
" except ValueError as e:\n"
" return str(e)\n")
assert "E004" not in {d["code"] for d in pd.analyze(src, "t.py")}
def test_return_in_else_terminates(self, pd):
"""else 分支 return 终止 → elif 分支流出时变量确定 (send_image 场景)"""
src = ("def f(args):\n"
" if isinstance(args, str):\n"
" p = 1\n"
" elif isinstance(args, dict):\n"
" p = 2\n"
" else:\n"
" return None\n"
" return p\n")
assert "E004" not in {d["code"] for d in pd.analyze(src, "t.py")}
def test_return_in_else_both_terminate(self, pd):
src = ("def f(x):\n"
" if x:\n"
" return 1\n"
" else:\n"
" return 2\n")
assert "E004" not in {d["code"] for d in pd.analyze(src, "t.py")}
# ── code_editor 写文件后自动检测集成 ──
class TestAutoDetectIntegration: